Closed Bug 1938938 Opened 5 months ago Closed 3 months ago

Duplicate remaining legacy telemetry probes into Glean (Address Bar)

Categories

(Firefox :: Address Bar, task, P3)

task

Tracking

()

RESOLVED FIXED
138 Branch
Tracking Status
firefox138 --- fixed

People

(Reporter: standard8, Assigned: florian)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

Attachments

(2 files)

There's a few probes that we currently want to keep recording, and we don't yet have Glean equivalents. We should add Glean equivalents and if possible use GIFFT to report them.

The probes for this bug are:

  • PLACES_AUTOCOMPLETE_1ST_RESULT_TIME_MS
  • PLACES_AUTOCOMPLETE_6_FIRST_RESULTS_TIME_MS
See Also: → 1938942

Since these are recorded entirely in urlbar code, I think we should add these to browser/components/urlbar/metrics.yaml.

Naming wise, I think we could go with urlbar.autocomplete.first_result_time & urlbar.autocomplete.sixth_result_time maybe?

They should probably be timing distributions in the Glean world.

An additional one to migrate as well:

  • FX_URLBAR_ZERO_PREFIX_DWELL_TIME_MS
    • Probably use urlbar.zero_prefix_dwell_time?

(In reply to Mark Banner (:standard8) from comment #2)

An additional one to migrate as well:

  • FX_URLBAR_ZERO_PREFIX_DWELL_TIME_MS
    • Probably use urlbar.zero_prefix_dwell_time?

I think we can just drop that one.

Assignee: nobody → florian
Status: NEW → ASSIGNED
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/12fb2bbf04b1 remove the FX_URLBAR_ZERO_PREFIX_DWELL_TIME_MS histogram, r=adw,urlbar-reviewers. https://hg.mozilla.org/integration/autoland/rev/3ab92bff2d13 migrate to Glean the PLACES_AUTOCOMPLETE_* histograms, r=Standard8,urlbar-reviewers.
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: